NodeScopeResolver analysed files not as global state and optional#2122
Closed
MartinMystikJonas wants to merge 1 commit intophpstan:1.9.xfrom
Closed
NodeScopeResolver analysed files not as global state and optional#2122MartinMystikJonas wants to merge 1 commit intophpstan:1.9.xfrom
MartinMystikJonas wants to merge 1 commit intophpstan:1.9.xfrom
Conversation
Contributor
Author
|
Now I see this global state is used by rector. Would you preffer to just make it optional and kept as global state? It would be enough for our use case. I just want to remove global state when I was already making changes to it. Or make |
Contributor
Author
|
I created simpler version that only makes setting analysedPaths optionsl for NodeScopeREsolver (used to limit analysis of trait outside of analysedPaths). See #2123 |
Contributor
|
Hi, sorry for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ondrejmirtes We discussed this on our friday call. I prepared PR that would make NodeScopeResolver usable for our use case of collecting latte templates context.
analysedFilesare not global state anymore but passed as optional parameter toresolveNodesandresolveStmtNodesNodeScopeResolverwill not limit what traits it resolvesI split
resolveStmtNodesto publicresolveStmtNodeswhich can setanalysedFilesand privateiterateStmtNodesused internally inNodeScopeResolverto avoid resetinganalysedFilesor passing it arround all private methods ofNodeScopeResolver